444060c3eb
- Introduced `critic`, an independent adversarial reviewer for security and correctness. - Added `fable-orchestrator` to manage task routing and verification. - Implemented `gauntlet-critic` for fresh-context evaluation of gauntlet rounds. - Created `planner` for generating executable implementation plans with dependencies. - Developed `security-auditor` for application security reviews and audits. - Established `system-steward` to improve agent prompts and skills based on verified failures. - Added `dev-loop` skill for autonomous development loops over repositories. - Implemented `gauntlet-loop` skill for iterative quality benchmarking against reference standards. - Updated project settings to utilize the new orchestrator agent. - Created documentation for `GAUNTLET.md`, `PROGRESS.md`, and `REFERENCE_BAR.md` to track project status and quality benchmarks. - Added detailed prompting style guide to enhance understanding of prompt patterns and agentic loops.
19 lines
2.4 KiB
Markdown
19 lines
2.4 KiB
Markdown
---
|
||
name: design-review
|
||
description: Heuristic + accessibility review of implemented user-facing UI against its design spec and the design system, AFTER the build. Returns P0–P3 findings with file/line evidence; read-only. Owner: ux-ui-designer; runs concurrently with the verifier. Required at medium+ risk for any user-facing change.
|
||
allowed-tools: Read Grep Glob
|
||
---
|
||
|
||
Review what was actually built — templates, widgets, copy, states — against the spec (`docs/design/<feature>.md` if present), `docs/DESIGN_SYSTEM.md`, and these lenses. Read-only: findings and smallest fixes, never patches.
|
||
|
||
1. **Task efficiency.** Steps/taps to complete the user's job vs the spec's target; unnecessary inputs where a preset, dropdown, or default would do; the primary action visually primary on every screen.
|
||
2. **State completeness.** Every state the spec names exists in code: empty, loading, error, success, and — for offline-capable surfaces — offline, queued, sync-pending, sync-rejected. Grep for the state handling, don't assume; an unhandled state is at least P1.
|
||
3. **Consistency.** Components, spacing, and naming match `DESIGN_SYSTEM.md` and neighboring screens; new one-off patterns without a design-system entry are findings.
|
||
4. **Copy + i18n.** Every user-visible string localized in all supported locales (grep for hardcoded literals in templates/widgets); tone and terminology match the copy rules; errors say what to DO, not just what failed.
|
||
5. **Accessibility.** Tap targets ≥ 48dp, WCAG AA contrast, focus order, labels on icon-only controls, form errors announced next to their fields.
|
||
6. **Platform ergonomics.** Mobile: reachability, keyboard types, sunlight-legible contrast, battery-conscious patterns. Web: keyboard navigation, dense-screen scanability, bulk-action affordances.
|
||
|
||
Rank findings **P0** (blocks the user's job or data comprehension — e.g. money state invisible), **P1** (missing state, broken i18n/a11y on a core path), **P2** (inconsistency, inefficiency), **P3** (polish). Each finding: evidence (file/line or reproduction), impact, smallest fix. Do not restate the spec, praise the work, or invent P3s to seem thorough — state `none` after meaningful checks if the build holds.
|
||
|
||
Return exactly: **Verdict** (accept / accept with follow-ups / return to builder) · **Findings** (P0–P3 or `none`) · **Checks performed** (lenses run, files inspected) · **Design-system delta** (or `none`).
|