kibin/fiberops-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(e2e): fix spec selectors for payments and remittances #1

Merged
kibin merged 1 commits from fix/e2e-spec-selectors into main 2026-03-31 03:57:18 +00:00
Conversation 1 Commits 1 Files Changed 2 +11 -10
kibin commented 2026-03-31 03:24:36 +00:00
Owner
Copy Link

Summary

Fix Playwright strict mode violations in payments and remittances E2E specs.

Workitem

Workitem: Internal test fix — no Plane workitem

Type

  • Bug fix

Changes

  • Fix text=Amount ambiguous selector → scoped to .fixed.inset-0
  • Fix text=Submit Remittance strict violation → use getByRole(heading)
  • Fix text=Remittance Details → use getByRole(heading)
  • Fix empty state test → wait for skeleton to clear before asserting

How to test

  1. Run npx playwright test e2e/payments.spec.ts e2e/remittances.spec.ts
  2. All 10 tests should pass

Checklist

  • Follows project conventions
  • No leftover console.log
  • No hardcoded secrets
  • E2E spec updated
## Summary Fix Playwright strict mode violations in payments and remittances E2E specs. ## Workitem Workitem: Internal test fix — no Plane workitem ## Type - [x] Bug fix ## Changes - Fix `text=Amount` ambiguous selector → scoped to `.fixed.inset-0` - Fix `text=Submit Remittance` strict violation → use `getByRole(heading)` - Fix `text=Remittance Details` → use `getByRole(heading)` - Fix empty state test → wait for skeleton to clear before asserting ## How to test 1. Run `npx playwright test e2e/payments.spec.ts e2e/remittances.spec.ts` 2. All 10 tests should pass ## Checklist - [x] Follows project conventions - [x] No leftover console.log - [x] No hardcoded secrets - [x] E2E spec updated
kibin added 1 commit 2026-03-31 03:24:37 +00:00
test: fix E2E spec selectors for payments and remittances (strict mode, heading role) e4f04cf38e
nemo approved these changes 2026-03-31 03:57:10 +00:00
nemo left a comment
Collaborator
Copy Link

✅ Nemo approved — E2E spec selectors verified. Strict mode violations fixed, all 4 tests passing. LGTM 🐠

✅ **Nemo approved** — E2E spec selectors verified. Strict mode violations fixed, all 4 tests passing. LGTM 🐠
kibin merged commit 5843499815 into main 2026-03-31 03:57:18 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
nemo
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
nemo kibin
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kibin/fiberops-web#1
Delete Branch "fix/e2e-spec-selectors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?