fix(254): move invoice modal buttons to sticky footer

fix(254): modal scrollable with sticky footer
Merge pull request 'fix: remove public COPY — no public dir in repo' (#24 ) from fix/remove-public-copy into main
2026-04-01 07:45:02 +00:00 · 2026-04-01 07:44:53 +00:00 · 2026-04-01 05:03:32 +00:00 · 2026-04-01 05:03:16 +00:00 · 2026-04-01 04:56:36 +00:00 · 2026-04-01 04:56:21 +00:00
6 changed files with 50 additions and 13 deletions
--- a/1
+++ b/1
@@ -14,7 +14,6 @@ ENV NEXT_TELEMETRY_DISABLED=1
 COPY --from=builder /app/package*.json ./
 COPY --from=builder /app/.next ./.next
 COPY --from=builder /app/public ./public
 COPY --from=builder /app/node_modules ./node_modules
 EXPOSE 3000
--- a/app/(app)/invoices/page.tsx
+++ b/app/(app)/invoices/page.tsx
@@ -154,7 +154,20 @@ export default function InvoicesPage() {
      </Card>
      {/* Invoice Detail Modal */}
-      <Modal isOpen={!!selected} onClose={() => setSelected(null)} title={`Invoice ${selected?.invoiceNumber ?? ""}`} className="max-w-lg">
+      <Modal
        isOpen={!!selected}
        onClose={() => setSelected(null)}
        title={`Invoice ${selected?.invoiceNumber ?? ""}`}
        className="max-w-lg"
        footer={selected ? (
          <>
            {selected.status !== "VOID" && selected.status !== "PAID" && (
              <Button variant="danger" size="sm" onClick={() => voidInvoice.mutate(selected.id)} isLoading={voidInvoice.isPending}>Void Invoice</Button>
            )}
            <Button variant="outline" size="sm" onClick={() => setSelected(null)}>Close</Button>
          </>
        ) : undefined}
      >
        {selected && (
          <div className="space-y-4">
            <div className="bg-gray-50 rounded-lg p-4 space-y-2 text-sm">
@@ -196,13 +209,6 @@ export default function InvoicesPage() {
                  disabled={!payForm.amount}>Record Payment</Button>
              </div>
            )}
            <div className="flex justify-between pt-1">
              {selected.status !== "VOID" && selected.status !== "PAID" && (
                <Button variant="danger" size="sm" onClick={() => voidInvoice.mutate(selected.id)} isLoading={voidInvoice.isPending}>Void Invoice</Button>
              )}
              <Button variant="outline" size="sm" onClick={() => setSelected(null)} className="ml-auto">Close</Button>
            </div>
          </div>
        )}
      </Modal>
--- a/pages/_document.tsx
+++ b/pages/_document.tsx
@@ -0,0 +1,12 @@
 import { Html, Head, Main, NextScript } from 'next/document';
 export default function Document() {
  return (
    <Html lang="en">
      <Head />
      <body>
        <Main />
        <NextScript />
      </body>
    </Html>
  );
 }
--- a/pages/_error.tsx
+++ b/pages/_error.tsx
@@ -0,0 +1,14 @@
 // Custom error page — prevents Html import issue in Next.js pages router
 export default function Error({ statusCode }: { statusCode?: number }) {
  return (
    <div style={{ padding: '2rem', fontFamily: 'sans-serif' }}>
      <h1>{statusCode || 'Error'}</h1>
      <p>{statusCode === 404 ? 'Page not found' : 'An error occurred'}</p>
    </div>
  );
 }
 Error.getInitialProps = ({ res, err }: any) => {
  const statusCode = res ? res.statusCode : err ? err.statusCode : 404;
  return { statusCode };
 };
--- a/public/.gitkeep
+++ b/public/.gitkeep
--- a/src/components/ui/Modal.tsx
+++ b/src/components/ui/Modal.tsx
@@ -9,10 +9,11 @@ interface ModalProps {
  onClose: () => void;
  title: string;
  children: React.ReactNode;
  footer?: React.ReactNode;
  className?: string;
 }
-export function Modal({ isOpen, onClose, title, children, className }: ModalProps) {
+export function Modal({ isOpen, onClose, title, children, footer, className }: ModalProps) {
  const overlayRef = useRef<HTMLDivElement>(null);
  useEffect(() => {
@@ -31,8 +32,8 @@ export function Modal({ isOpen, onClose, title, children, className }: ModalProp
      className="fixed inset-0 z-50 flex items-center justify-center bg-black/40 p-4"
      onClick={(e) => e.target === overlayRef.current && onClose()}
    >
-      <div className={cn("w-full max-w-lg rounded-xl bg-white shadow-xl", className)}>
+      <div className={cn("w-full max-w-lg rounded-xl bg-white shadow-xl flex flex-col max-h-[90vh]", className)}>
-        <div className="flex items-center justify-between border-b border-gray-100 px-6 py-4">
+        <div className="flex items-center justify-between border-b border-gray-100 px-6 py-4 flex-shrink-0">
          <h3 className="text-base font-semibold text-gray-900">{title}</h3>
          <button
            onClick={onClose}
@@ -41,7 +42,12 @@ export function Modal({ isOpen, onClose, title, children, className }: ModalProp
            <X className="h-5 w-5" />
          </button>
        </div>
-        <div className="px-6 py-4">{children}</div>
+        <div className="px-6 py-4 overflow-y-auto flex-1">{children}</div>
        {footer && (
          <div className="flex items-center justify-end gap-2 border-t border-gray-100 px-6 py-3 flex-shrink-0">
            {footer}
          </div>
        )}
      </div>
    </div>
  );
Author	SHA1	Message	Date
kibin	c5826a34d0	fix(254): move invoice modal buttons to sticky footer	2026-04-01 07:45:02 +00:00
kibin	7de6d899f1	fix(254): modal scrollable with sticky footer	2026-04-01 07:44:53 +00:00
kibin	e582eb1693	Merge pull request 'fix: remove public COPY — no public dir in repo' (#24 ) from fix/remove-public-copy into main	2026-04-01 05:03:32 +00:00
Nemo (Claude Code)	41a90ad76e	fix: remove public COPY from Dockerfile, add public/.gitkeep	2026-04-01 05:03:16 +00:00
kibin	b880137084	Merge pull request 'fix: pages/_error and _document for build' (#23 ) from fix/pages-error-handler into main	2026-04-01 04:56:36 +00:00
Nemo (Claude Code)	fca3194801	fix: add pages/_error and _document to fix Html import in build	2026-04-01 04:56:21 +00:00
kibin	22c1df67c1	Merge pull request 'fix: force-dynamic on layouts — skip SSR static gen' (#22 ) from fix/force-dynamic-all-pages into main	2026-04-01 04:49:51 +00:00