9fdca2ccf7
Phase 05: 2 gap closure plans in 1 wave - 05-06: P0 tenant scoping fix (6 models) + CASL subject correction - 05-07: E2E test coverage gaps + Phase 2 verification correction - Both plans are parallel (Wave 1, no dependencies) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
9.1 KiB
9.1 KiB
phase, plan, type, wave, depends_on, files_modified, autonomous, gap_closure, must_haves
| phase | plan | type | wave | depends_on | files_modified | autonomous | gap_closure | must_haves | ||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 05-visibility-and-client-portal | 07 | execute | 1 |
|
true | true |
|
Purpose: Close the E2E test coverage gaps identified in the milestone audit and fix the outdated verification document that still shows a gap that was resolved. Output: Two new E2E workflow test suites and a corrected Phase 2 VERIFICATION.md.
<execution_context> @C:\Users\KevinAsprec.claude/get-shit-done/workflows/execute-plan.md @C:\Users\KevinAsprec.claude/get-shit-done/templates/summary.md </execution_context>
@.planning/PROJECT.md @.planning/ROADMAP.md @.planning/STATE.md @.planning/v1-MILESTONE-AUDIT.md @src/lib/__tests__/integration/e2e-workflows.test.ts @src/lib/services/inventory-service.ts @src/lib/services/asset-service.ts @src/lib/services/expense-service.ts @src/lib/services/portal-ticket-service.ts @.planning/phases/02-subscriber-and-billing-core/02-VERIFICATION.md Task 1: Add inventory/expense and portal ticket E2E workflows src/lib/__tests__/integration/e2e-workflows.test.ts Add two new describe blocks to the existing e2e-workflows.test.ts file. Follow the exact patterns established by the existing 3 workflows (same test helpers, same tenant setup, same cleanup approach, same trial balance verification pattern).**Workflow 4: Inventory Receiving -> Expense Recording -> Trial Balance**
Add a describe block "Workflow 4: Inventory Receiving and Expense Recording" with these tests:
1. "receives inventory items and creates balanced journal entries"
- Import and call inventory-service to receive stock (e.g., receiveStock or the appropriate function that creates an INBOUND/RECEIVED stock movement)
- Verify the stock movement was created
- Verify a journal entry was posted (DR Inventory asset account / CR Cash or AP)
- Verify the JE is balanced (debits === credits)
2. "records an expense with automatic journal entry"
- Import and call expense-service to create an expense (with category and vendor)
- Need to create an expense category and vendor first (use the appropriate service functions or direct prisma calls matching existing test patterns)
- Verify the expense was created
- Verify a journal entry was posted (DR Expense account / CR Cash or AP)
- Verify the JE is balanced
3. "trial balance remains balanced after inventory and expense transactions"
- Use JournalEntryService.getTrialBalance (same pattern as existing workflows)
- Assert total debits === total credits > 0
**Workflow 5: Portal Ticket Creation -> Staff Queue**
Add a describe block "Workflow 5: Portal Ticket Submission to Staff Queue" with these tests:
1. "subscriber creates portal ticket and it appears in staff ticket queue"
- Create a subscriber (use existing createSubscriber helper or the pattern from existing tests)
- Import and call portal-ticket-service's createPortalTicket (or equivalent function) to create a ticket as the subscriber
- This should trigger ensurePortalUser internally (creating a shadow User with CLIENT role)
- Verify the ticket was created with source=SUBSCRIBER
- Query tickets via ticket-service's list/search function (staff perspective) and verify the portal ticket appears in the results
2. "portal ticket has correct subscriber association"
- Verify the ticket's createdById links to the shadow portal user
- Verify the shadow user exists with role CLIENT
IMPORTANT:
- Reuse the existing test's tenant, users, and cleanup infrastructure. The existing beforeAll creates a tenant and users — extend it to also create any additional data needed (expense categories, vendors, inventory items).
- Add cleanup for new records in the existing afterAll block (expense categories, expenses, vendors, inventory items, stock movements, plus any portal-created users and tickets).
- Follow the existing import pattern at the top of the file.
- Check the actual function signatures in inventory-service.ts, expense-service.ts, and portal-ticket-service.ts before writing calls — use the exact parameter shapes those functions expect.
1. In the YAML frontmatter:
- Change `status: gaps_found` to `status: passed`
- Change `score: 4/5 must-haves verified` to `score: 5/5 must-haves verified`
- Remove or update the `gaps:` section — change the truth #3 status from `failed` to `fixed` and add a note that the fix was applied in billing-service.ts (status: InvoiceStatus.SENT, issuedAt: new Date()) and validated by Phase 5 E2E tests
2. In the body:
- Update Truth #3 status from "FAILED" to "VERIFIED (fixed post-verification)" in the Observable Truths table
- Add a brief note in the Evidence column: "Fixed: billing-service.ts now sets status=SENT and issuedAt on invoice creation. Validated by Phase 5 E2E billing workflow test."
- Update the Key Link "billing-service.ts -> Invoice (status=SENT)" from "NOT WIRED" to "WIRED" with note "Fixed post-initial-verification"
- Update BILL-03 requirement from "BLOCKED" to "SATISFIED" with note "Fixed: invoices now created as SENT"
- Update the Anti-Patterns section to mark the billing-service.ts issue as resolved
- Update the Gaps Summary section to note that the gap was resolved
- Add a re-verification note: "Re-verified: 2026-03-05 — gap closure confirmed"
3. Update the Score line in the body from "4/5" to "5/5".
Keep all other content intact. This is a documentation correction, not a rewrite.
<success_criteria>
- E2E test coverage now includes Phase 4 inventory/expense workflows
- E2E test coverage now includes portal ticket creation flow
- Phase 2 VERIFICATION.md accurately reflects the fixed state
- All existing tests continue to pass </success_criteria>