docs(03-05): complete technician management plan — Phase 3 complete

Tasks completed: 2/2 - Task 1: TechnicianProfile/JobTypeRate schema, migration, tenant scoping - Task 2: Technician service, compensation service, 6 APIs, 27 integration tests SUMMARY: .planning/phases/03-operational-modules/03-05-SUMMARY.md
2026-03-05 08:19:11 +08:00
parent fba2ba4bf9
commit f49bbf32b5
2 changed files with 167 additions and 13 deletions
--- a/.planning/STATE.md
+++ b/.planning/STATE.md
@@ -5,23 +5,23 @@
 See: .planning/PROJECT.md (updated 2026-03-04)

 **Core value:** ISP owners can see exactly where their money is — who owes what, what's been collected, what's been spent, and what the business actually looks like financially — in real time.
-**Current focus:** Phase 3 - Operational Modules
+**Current focus:** Phase 4 - Inventory and Expenses (Phase 3 complete)

 ## Current Position

-Phase: 3 of 5 (Operational Modules) — In progress
-Plan: 5 of 5 in phase 3 (16/20 total complete)
-Status: Phase 3 in progress. 03-01 (Zones), 03-02 (Collections/Remittances), 03-03 (Ticketing), 03-04 (Job Orders) complete.
-Last activity: 2026-03-05 — Completed 03-04-PLAN.md (Job Orders — 17 tests, bidirectional ticket sync, PENDING/IN_PROGRESS/COMPLETED/CANCELLED lifecycle)
+Phase: 3 of 5 (Operational Modules) — COMPLETE
+Plan: 5 of 5 in phase 3 (17/20 total complete)
+Status: Phase 3 complete. 03-01 (Zones), 03-02 (Collections/Remittances), 03-03 (Ticketing), 03-04 (Job Orders), 03-05 (Technician Compensation) all complete.
+Last activity: 2026-03-05 — Completed 03-05-PLAN.md (Technician Management — 27 tests, hybrid compensation, PER_JOB/SALARY/HYBRID models)

-Progress: [████████████████░] 80% (16/20 plans across all phases)
+Progress: [█████████████████░░░] 85% (17/20 plans across all phases)

 ## Performance Metrics

 **Velocity:**
- Total plans completed: 10
+- Total plans completed: 11
 - Average duration: 9.5 min
- Total execution time: 95 min
+- Total execution time: 104 min

 **By Phase:**

@@ -29,11 +29,11 @@ Progress: [████████████████░] 80% (16/20 plans
 |-------|-------|-------|----------|
 | 01-foundation | 5/5 complete | 41 min | 8.2 min |
 | 02-subscriber-and-billing-core | 5/5 complete | 57 min | 11.4 min |
-| 03-operational-modules | 4/5 in progress | ~56 min | ~14 min |
+| 03-operational-modules | 5/5 complete | ~65 min | ~13 min |

 **Recent Trend:**
- Last 10 plans: 01-04 (7 min), 01-05 (6 min), 02-01 (7 min), 02-03 (7 min), 02-02 (16 min), 02-04 (12 min), 02-05 (8 min), 03-01 (15 min), 03-02 (11 min), 03-04 (6 min)
- Trend: stable — 03-04 migration applied cleanly, 17 tests passed on second run (1 fix for FK cleanup ordering)
+- Last 10 plans: 01-05 (6 min), 02-01 (7 min), 02-03 (7 min), 02-02 (16 min), 02-04 (12 min), 02-05 (8 min), 03-01 (15 min), 03-02 (11 min), 03-04 (6 min), 03-05 (9 min)
+- Trend: stable — 03-05 migration applied cleanly, all 27 tests passed on first run

 *Updated after each plan completion*

@@ -115,6 +115,10 @@ Recent decisions affecting current work:
 - [03-04]: checkTicketRevertToOpen only triggers on ASSIGNED tickets — RESOLVED/CLOSED tickets not reverted even if all jobs are cancelled
 - [03-04]: COMPLETED requires outcomeNotes validated at service layer (not API) — enforces completeness regardless of caller
 - [03-04]: TECHNICIAN self-service via getMyJobOrders delegates to listJobOrders with assignedToId filter; GET /api/job-orders checks !ADMIN && !OFFICE_STAFF for auto-filter to handle multi-role users
+- [03-05]: User.technicianProfiles is one-to-many (not one-to-one) — Prisma requires @unique on FK for one-to-one; compound @@unique([tenantId,userId]) enforces one-per-tenant at DB; findFirst enforces at app layer
+- [03-05]: Missing job type rate defaults to 0 bonus — rateMap.get(jobType) ?? Decimal(0); not an error per design spec
+- [03-05]: SALARY model detail returns jobs with rate=0 — consistent API shape across all 3 models; all detail responses have a jobs array
+- [03-05]: Compensation cleanup order in tests: jobOrders -> tickets -> ticketCategories -> jobTypeRates -> technicianProfiles -> zoneAssignments -> subscribers -> zones -> servicePlans -> users -> tenant

 ### Pending Todos

@@ -132,6 +136,6 @@ None.

 ## Session Continuity

-Last session: 2026-03-05T00:04:26Z
-Stopped at: Completed 03-04-PLAN.md (Job Orders — 17 tests, bidirectional ticket sync, lifecycle enforcement)
+Last session: 2026-03-05T00:17:08Z
+Stopped at: Completed 03-05-PLAN.md (Technician Management — 27 tests, hybrid compensation, Phase 3 complete)
 Resume file: None
--- a/.planning/phases/03-operational-modules/03-05-SUMMARY.md
+++ b/.planning/phases/03-operational-modules/03-05-SUMMARY.md
@@ -0,0 +1,150 @@
+---
+phase: 03-operational-modules
+plan: "05"
+subsystem: api
+tags: [prisma, postgresql, technician, compensation, per-job, salary, hybrid, job-type-rates, tenant-isolation]
+
+# Dependency graph
+requires:
+  - phase: 03-04
+    provides: JobOrder model (COMPLETED status used for per-job compensation calculation), job type string on each order
+  - phase: 03-01
+    provides: Zone model (technicianProfile.zoneId FK)
+  - phase: 01-04
+    provides: CASL AppSubjects/AppActions types that TechnicianProfile and JobTypeRate are added to
+provides:
+  - TechnicianProfile model with CompensationModel enum (PER_JOB/SALARY/HYBRID), skills[], zoneId, monthlySalary
+  - JobTypeRate model for tenant-level per-job bonus rates by jobType string
+  - technician-service.ts: createTechnicianProfile, updateTechnicianProfile, getTechnicianProfile, getTechnicianProfileByUserId, listTechnicians
+  - compensation-service.ts: getCompensationSummary (per-technician totals for all 3 models), getTechnicianCompensationDetail (job-by-job)
+  - 6 API routes: GET/POST /api/technicians, GET/PUT /api/technicians/[id], GET /api/technicians/[id]/compensation, GET/POST /api/job-type-rates, PUT /api/job-type-rates/[id], GET /api/reports/compensation
+  - 27 integration tests: all 3 compensation models, edge cases, cross-tenant isolation
+affects:
+  - Phase 4 (inventory may link to technicianProfiles for equipment checkout)
+  - Phase 5 (reporting dashboards may aggregate compensation data)
+
+# Tech tracking
+tech-stack:
+  added: []
+  patterns:
+    - "Missing rate = 0: rateMap.get(jobType) ?? new Prisma.Decimal(0) — no error on unknown job types"
+    - "CompensationModel switch in service: PER_JOB baseSalary=0, SALARY jobBonus=0, HYBRID both"
+    - "Cross-model validation at service layer: monthlySalary required check before profile creation"
+    - "Prisma one-to-many for User.technicianProfiles[]: compound @@unique([tenantId, userId]) enforces one-per-tenant at DB level"
+
+key-files:
+  created:
+    - prisma/migrations/20260305000851_add_technician_profiles/migration.sql
+    - src/lib/services/technician-service.ts
+    - src/lib/services/compensation-service.ts
+    - src/app/api/technicians/route.ts
+    - src/app/api/technicians/[id]/route.ts
+    - src/app/api/technicians/[id]/compensation/route.ts
+    - src/app/api/job-type-rates/route.ts
+    - src/app/api/job-type-rates/[id]/route.ts
+    - src/app/api/reports/compensation/route.ts
+    - src/lib/__tests__/compensation-service.test.ts
+  modified:
+    - prisma/schema.prisma
+    - src/lib/prisma-tenant.ts
+    - src/lib/casl/types.ts
+    - src/lib/casl/permissions.ts
+
+key-decisions:
+  - "User.technicianProfiles as one-to-many (not one-to-one): Prisma one-to-one requires @unique on FK field, incompatible with compound @@unique([tenantId,userId]); one-to-many + findFirst enforces same logical constraint"
+  - "Missing job type rate defaults to 0: rateMap.get() ?? Decimal(0) — no throws on unknown job types per plan spec"
+  - "SALARY model detail includes job list with rate=0 per job: preserves consistent detail shape across all models"
+  - "TechnicianProfile and JobTypeRate added to CASL AppSubjects: ADMIN gets manage-all, OFFICE_STAFF gets read+update on TechnicianProfile and read on JobTypeRate"
+  - "Cleanup order in tests: jobOrders -> tickets -> ticketCategories -> jobTypeRates -> technicianProfiles -> zoneAssignments -> subscribers -> zones -> servicePlans -> users -> tenant"
+
+patterns-established:
+  - "Compensation calculation: load profiles, load all rates into Map, iterate profiles with per-job filter by completedAt range"
+  - "Rate lookup: buildRateMap() returns Map<jobType, Decimal>; missing key = 0 (not error)"
+  - "All 3 models handled by model-switch logic in service: if PER_JOB|HYBRID -> jobBonus else 0; if SALARY|HYBRID -> baseSalary else 0"
+
+# Metrics
+duration: 9min
+completed: 2026-03-05
+---
+
+# Phase 3 Plan 05: Technician Management Summary
+
+**TechnicianProfile/JobTypeRate models with hybrid compensation engine (PER_JOB/SALARY/HYBRID), missing-rate-defaults-to-0 edge case, 6 API routes, and 27 passing integration tests — Phase 3 complete**
+
+## Performance
+
+- **Duration:** 9 min
+- **Started:** 2026-03-05T00:07:21Z
+- **Completed:** 2026-03-05T00:17:08Z
+- **Tasks:** 2
+- **Files modified:** 14
+
+## Accomplishments
+- TechnicianProfile model with CompensationModel enum (PER_JOB/SALARY/HYBRID), skills array, zone FK, monthlySalary; JobTypeRate model with @@unique([tenantId,jobType]); migration applied
+- CompensationService calculates all 3 models: PER_JOB (job bonuses only), SALARY (base only), HYBRID (base + bonuses); missing rates default to 0 (not error); only COMPLETED jobs in date range count
+- 6 API routes: full CRUD for technician profiles, job type rates CRUD, compensation detail per technician, compensation summary report
+- 27 integration tests covering all 3 models, missing rate edge case, CANCELLED/PENDING exclusion, date range filtering, summary + detail breakdown, cross-tenant isolation — all green on first run
+
+## Task Commits
+
+Each task was committed atomically:
+
+1. **Task 1: TechnicianProfile/JobTypeRate schema, migration, tenant scoping** - `230b0ec` (feat)
+2. **Task 2: Technician service, compensation service, APIs, and 27 integration tests** - `fba2ba4` (feat)
+
+**Plan metadata:** (docs commit below)
+
+## Files Created/Modified
+- `prisma/schema.prisma` - Added CompensationModel enum, TechnicianProfile model, JobTypeRate model, reverse relations on User and Zone
+- `prisma/migrations/20260305000851_add_technician_profiles/migration.sql` - Migration adding technician_profiles and job_type_rates tables
+- `src/lib/prisma-tenant.ts` - Added technicianProfile and jobTypeRate to TENANT_SCOPED_MODELS with full 12-operation extension blocks
+- `src/lib/casl/types.ts` - Added TechnicianProfile and JobTypeRate to AppSubjects union
+- `src/lib/casl/permissions.ts` - OFFICE_STAFF: read+update TechnicianProfile, read JobTypeRate
+- `src/lib/services/technician-service.ts` - Full CRUD: createTechnicianProfile (validates TECHNICIAN role), updateTechnicianProfile, getTechnicianProfile, getTechnicianProfileByUserId, listTechnicians
+- `src/lib/services/compensation-service.ts` - getCompensationSummary, getTechnicianCompensationDetail with all 3 models and missing-rate-defaults-to-0
+- `src/app/api/technicians/route.ts` - GET (list), POST (create)
+- `src/app/api/technicians/[id]/route.ts` - GET (single), PUT (update)
+- `src/app/api/technicians/[id]/compensation/route.ts` - GET (job-by-job detail for period)
+- `src/app/api/job-type-rates/route.ts` - GET (list), POST (create)
+- `src/app/api/job-type-rates/[id]/route.ts` - PUT (update rate/description/isActive)
+- `src/app/api/reports/compensation/route.ts` - GET (summary report with optional technician filter)
+- `src/lib/__tests__/compensation-service.test.ts` - 27 integration tests
+
+## Decisions Made
+- User.technicianProfiles as one-to-many (not one-to-one): Prisma requires @unique on the FK field for one-to-one, incompatible with compound @@unique([tenantId,userId]); one-to-many + findFirst provides the same logical guarantee at the application layer
+- Missing job type rate = 0 bonus: rateMap.get(jobType) ?? Decimal(0) — plan spec requires this to be a non-error default
+- SALARY model detail returns jobs with rate=0 per job: preserves consistent API shape across all 3 models (detail always has a jobs array)
+- TechnicianProfile and JobTypeRate added to CASL AppSubjects: enables withPermission() middleware to gate these endpoints; ADMIN gets manage-all via existing rule
+
+## Deviations from Plan
+
+### Auto-fixed Issues
+
+**1. [Rule 1 - Bug] Prisma one-to-one relation validation failure for User.technicianProfile**
+- **Found during:** Task 1 (migration)
+- **Issue:** Plan specified `TechnicianProfile?` on User (one-to-one) but Prisma validation requires `@unique` on the FK field (`userId`) for one-to-one relations. The compound `@@unique([tenantId, userId])` does not satisfy Prisma's check.
+- **Fix:** Changed User side to `technicianProfiles TechnicianProfile[]` (one-to-many); application code uses `findFirst` to enforce the one-per-tenant constraint; database @@unique([tenantId, userId]) enforces the constraint at DB level
+- **Files modified:** prisma/schema.prisma
+- **Verification:** Migration applied successfully; tsc --noEmit passes
+- **Committed in:** 230b0ec (Task 1 commit)
+
+---
+
+**Total deviations:** 1 auto-fixed (1 bug — Prisma schema validation)
+**Impact on plan:** Minimal. The logical constraint (one profile per user per tenant) is preserved at the DB level. No scope creep.
+
+## Issues Encountered
+None — all 27 tests passed on the first run.
+
+## User Setup Required
+None - no external service configuration required.
+
+## Next Phase Readiness
+- Phase 3 (Operational Modules) is now 100% complete: Zones, Collections, Ticketing, Job Orders, Technician Management all done
+- TechnicianProfile is ready for Phase 4 inventory integration (equipment checkout by technician)
+- Compensation report is ready for Phase 5 dashboard/reporting integration
+- CASL permission matrix is extended with TechnicianProfile and JobTypeRate for Phase 4/5 use
+
+---
+*Phase: 03-operational-modules*
+*Completed: 2026-03-05*