kibin/NetForge
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs(04-02): complete asset management plan — Phase 4 complete

Browse Source 
Tasks completed: 2/2
- AssetService with assign, return, dispose, history
- 11 integration tests all passing

SUMMARY: .planning/phases/04-inventory-expenses-and-financial-reports/04-02-SUMMARY.md

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
kevin-asprec
2026-03-05 14:34:09 +08:00
parent 0f733627bd
commit e3a177f194
2 changed files with 128 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
.planning/STATE.md
View File

@@ -5,23 +5,23 @@
See: .planning/PROJECT.md (updated 2026-03-04) See: .planning/PROJECT.md (updated 2026-03-04)
**Core value:** ISP owners can see exactly where their money is — who owes what, what's been collected, what's been spent, and what the business actually looks like financially — in real time. **Core value:** ISP owners can see exactly where their money is — who owes what, what's been collected, what's been spent, and what the business actually looks like financially — in real time.
**Current focus:** Phase 4 - Inventory and Expenses (Phase 3 complete) **Current focus:** Phase 4 complete. Ready for Phase 5.
## Current Position ## Current Position
Phase: 4 of 5 (Inventory, Expenses, and Financial Reports) Phase: 4 of 5 (Inventory, Expenses, and Financial Reports)
Plan: 4 of 5 in phase 4 (21/22 total complete) Plan: 5 of 5 in phase 4 (22/22 total complete)
Status: In progress. 04-01, 04-03, and 04-05 complete. Status: Phase 4 complete. All plans done: 04-01, 04-02, 04-03, 04-05.
Last activity: 2026-03-05 — Completed 04-05-PLAN.md (Financial Reports — 16 tests, Trial Balance, Income Statement, Balance Sheet, drill-down) Last activity: 2026-03-05 — Completed 04-02-PLAN.md (Asset Management — 11 tests, assign/return/dispose/history)
Progress: [█████████████████████] 95% (21/22 plans across all phases) Progress: [██████████████████████] 100% (22/22 plans across all phases)
## Performance Metrics ## Performance Metrics
**Velocity:** **Velocity:**
- Total plans completed: 14 - Total plans completed: 15
- Average duration: 11 min - Average duration: 10.3 min
- Total execution time: 147 min - Total execution time: 155 min
**By Phase:** **By Phase:**
@@ -30,11 +30,11 @@ Progress: [█████████████████████] 95%
| 01-foundation | 5/5 complete | 41 min | 8.2 min | | 01-foundation | 5/5 complete | 41 min | 8.2 min |
| 02-subscriber-and-billing-core | 5/5 complete | 57 min | 11.4 min | | 02-subscriber-and-billing-core | 5/5 complete | 57 min | 11.4 min |
| 03-operational-modules | 5/5 complete | ~65 min | ~13 min | | 03-operational-modules | 5/5 complete | ~65 min | ~13 min |
| 04-inventory-expenses-reports | 3/5 complete | 43 min | 14.3 min | | 04-inventory-expenses-reports | 5/5 complete | 51 min | 12.8 min |
**Recent Trend:** **Recent Trend:**
- Last 10 plans: 02-04 (12 min), 02-05 (8 min), 03-01 (15 min), 03-02 (11 min), 03-04 (6 min), 03-05 (9 min), 04-01 (16 min), 04-03 (17 min), 04-05 (10 min) - Last 10 plans: 02-05 (8 min), 03-01 (15 min), 03-02 (11 min), 03-04 (6 min), 03-05 (9 min), 04-01 (16 min), 04-03 (17 min), 04-05 (10 min), 04-02 (8 min)
- Trend: stable — 04-05 all 16 tests passed, service already existed, API routes + tests only - Trend: stable — 04-02 all 11 tests passed first run, clean execution
*Updated after each plan completion* *Updated after each plan completion*
@@ -133,6 +133,12 @@ Recent decisions affecting current work:
- [04-05]: FinancialReportService already existed — 04-05 created API routes and tests only - [04-05]: FinancialReportService already existed — 04-05 created API routes and tests only
- [04-05]: All 3 financial reports derived entirely from POSTED JE lines — no stored balances - [04-05]: All 3 financial reports derived entirely from POSTED JE lines — no stored balances
- [04-05]: Balance Sheet Net Income computed inline from revenue - expenses (beginning of time to asOfDate) - [04-05]: Balance Sheet Net Income computed inline from revenue - expenses (beginning of time to asOfDate)
- [04-02]: AssetService delegates all movement recording to InventoryService.recordMovement — no direct StockMovement writes
- [04-02]: Disposal JE created separately before DISPOSED movement — InventoryService only auto-creates JEs for RECEIVED
- [04-02]: getCurrentLocation derives from latest movement's to-fields (null for DISPOSED)
- [04-02]: returnAsset always returns to main-warehouse — single warehouse model sufficient for ISP scale
- [04-02]: History name resolution uses batch queries then Map lookup — avoids N+1
- [04-02]: Asset cleanup order in tests: stockMovements -> inventoryItems -> journalEntryLines -> null reversesEntryId -> journalEntries -> subscribers -> servicePlans -> accountingPeriods -> accounts -> users -> tenant
### Pending Todos ### Pending Todos
@@ -150,6 +156,6 @@ None.
## Session Continuity ## Session Continuity
Last session: 2026-03-05T04:35:00Z Last session: 2026-03-05T05:11:00Z
Stopped at: Completed 04-05-PLAN.md (Financial Reports — 16 tests, Trial Balance, Income Statement, Balance Sheet, drill-down) Stopped at: Completed 04-02-PLAN.md (Asset Management — 11 tests, assign/return/dispose/history). Phase 4 complete.
Resume file: None Resume file: None

109
.planning/phases/04-inventory-expenses-and-financial-reports/04-02-SUMMARY.md Normal file
View File

@@ -0,0 +1,109 @@
---
phase: 04-inventory-expenses-and-financial-reports
plan: 02
subsystem: inventory
tags: [asset-management, serialized-tracking, disposal, write-off, journal-entry, location-history]
# Dependency graph
requires:
- phase: 04-01
provides: InventoryService.recordMovement, InventoryItem/StockMovement models, COA accounts 1200/2010
- phase: 02-02
provides: JournalEntryService.createEntry for disposal write-off JE
provides:
- AssetService with assignToSubscriber, assignToTechnician, returnAsset, disposeAsset, getAssetHistory
- API routes for assign, return, dispose, and history
- Admin-only disposal with write-off JE (DR 5030, CR 1200)
- Chronological location history with resolved names
affects: []
# Tech tracking
tech-stack:
added: []
patterns:
- "Asset lifecycle builds on immutable movement ledger (no new models)"
- "Role-based authorization at service layer (userRoles parameter)"
- "Location name resolution via batch query + map lookup"
key-files:
created:
- src/lib/services/asset-service.ts
- src/lib/__tests__/asset-service.test.ts
- src/app/api/inventory/items/[id]/assign/route.ts
- src/app/api/inventory/items/[id]/return/route.ts
- src/app/api/inventory/items/[id]/dispose/route.ts
- src/app/api/inventory/items/[id]/history/route.ts
modified: []
key-decisions:
- "AssetService delegates all movement recording to InventoryService.recordMovement — no direct StockMovement writes"
- "Disposal JE created separately before movement record — InventoryService only auto-creates JEs for RECEIVED"
- "getCurrentLocation derives from latest movement's to-fields (null for DISPOSED)"
- "returnAsset always returns to main-warehouse — single warehouse model sufficient for ISP scale"
- "History name resolution uses batch queries (subscribers + users) then Map lookup — avoids N+1"
patterns-established:
- "Service-layer role check via userRoles array parameter (not CASL) for admin-only operations"
# Metrics
duration: 8min
completed: 2026-03-05
---
# Phase 4 Plan 2: Asset Management Summary
**Asset lifecycle on immutable movement ledger — assign to subscriber/technician, return with condition, admin-only disposal with write-off JE (DR 5030, CR 1200), chronological location history**
## Performance
- **Duration:** 8 min
- **Started:** 2026-03-05T05:03:22Z
- **Completed:** 2026-03-05T05:11:00Z
- **Tasks:** 2
- **Files created:** 6
## Accomplishments
- AssetService with full lifecycle: assign, return, dispose, history
- Admin-only disposal creates write-off JE (DR 5030 Equipment Expense, CR 1200 Equipment Inventory)
- Chronological location history with resolved subscriber/technician/warehouse names
- 11 integration tests all passing covering assignment, return, disposal auth, history, and full lifecycle
## Task Commits
Each task was committed atomically:
1. **Task 1: AssetService and API routes** - `eb29d6e` (feat)
2. **Task 2: Asset service tests** - `0f73362` (test)
## Files Created/Modified
- `src/lib/services/asset-service.ts` - AssetService: assignToSubscriber, assignToTechnician, returnAsset, disposeAsset, getAssetHistory, getCurrentLocation
- `src/app/api/inventory/items/[id]/assign/route.ts` - POST assign (SUBSCRIBER or TECHNICIAN)
- `src/app/api/inventory/items/[id]/return/route.ts` - POST return with condition
- `src/app/api/inventory/items/[id]/dispose/route.ts` - POST dispose (admin only, 403 for non-admin)
- `src/app/api/inventory/items/[id]/history/route.ts` - GET chronological timeline
- `src/lib/__tests__/asset-service.test.ts` - 11 integration tests
## Decisions Made
- AssetService delegates all movement recording to InventoryService.recordMovement — no direct StockMovement writes
- Disposal JE created separately before movement record — InventoryService only auto-creates JEs for RECEIVED movements
- getCurrentLocation derives from latest movement's toLocationType/toLocationId (null for DISPOSED)
- returnAsset always returns to "main-warehouse" — single warehouse model sufficient for ISP scale
- History name resolution uses batch queries then Map lookup — avoids N+1 query pattern
## Deviations from Plan
None - plan executed exactly as written.
## Issues Encountered
None.
## User Setup Required
None - no external service configuration required.
## Next Phase Readiness
- Phase 4 now complete (all 5 plans: 04-01 Inventory, 04-02 Asset Management, 04-03 Expenses, 04-05 Financial Reports)
- Ready for Phase 5
---
*Phase: 04-inventory-expenses-and-financial-reports*
*Completed: 2026-03-05*